Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal for removing volunteers #222

Merged
merged 5 commits into from
Mar 31, 2022
Merged

Modal for removing volunteers #222

merged 5 commits into from
Mar 31, 2022

Conversation

hujoseph99
Copy link
Contributor

Ticket link

Closes #159

Implementation description

  • Created a modal for removing volunteers.

Steps to test

  1. Open the app
  2. Go to Remove Volunteer Demo in menu bar
  3. Enter a name of a volunteer you would like to remove
  4. Verify that the modal works and looks as expected

What should reviewers focus on?

  • Styling of the modal matches mockup

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@hujoseph99 hujoseph99 requested a review from a team March 19, 2022 18:28
@github-actions
Copy link

github-actions bot commented Mar 19, 2022 •
edited
Loading

Visit the preview URL for this PR (updated for commit 8500f16):

https://sistering-dev--pr222-joseph-remove-volunt-m7hutvuv.web.app

(expires Thu, 07 Apr 2022 23:05:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

LenaNguyen
LenaNguyen requested changes Mar 21, 2022
View reviewed changes
Copy link
Member

@LenaNguyen LenaNguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple styling things!

frontend/src/components/admin/RemoveVolunteerModal.tsx Show resolved Hide resolved
frontend/src/components/admin/RemoveVolunteerModal.tsx Outdated Show resolved Hide resolved
frontend/src/components/admin/RemoveVolunteerModal.tsx Show resolved Hide resolved
@hujoseph99 hujoseph99 force-pushed the joseph/remove-volunteer-modal branch from 7665f62 to 147acf3 Compare March 25, 2022 21:36
LenaNguyen
LenaNguyen previously approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@LenaNguyen LenaNguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hujoseph99 hujoseph99 force-pushed the joseph/remove-volunteer-modal branch from 147acf3 to 8df6758 Compare March 28, 2022 23:22
@hujoseph99
Copy link
Contributor Author

Had to resolve some merge conflicts so need re-review I believe

LenaNguyen
LenaNguyen requested changes Mar 29, 2022
View reviewed changes
frontend/src/components/pages/Default.tsx Outdated Show resolved Hide resolved
frontend/src/constants/Routes.ts Outdated Show resolved Hide resolved
@hujoseph99 hujoseph99 merged commit 38c7f5c into main Mar 31, 2022
@hujoseph99 hujoseph99 deleted the joseph/remove-volunteer-modal branch March 31, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LenaNguyen LenaNguyen LenaNguyen approved these changes

Assignees
No one assigned
Labels
ship it 🚢
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove volunteer modal
3 participants
@hujoseph99 @LenaNguyen @sherryhli