Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create AdminSchedulePostingPage #223

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Create AdminSchedulePostingPage #223

merged 1 commit into from
Mar 21, 2022

Conversation

hujoseph99
Copy link
Contributor

Ticket link

Closes #194

Implementation description

  • Created the component AdminSchedulePostingPage

Steps to test

  1. Go to http://localhost:3000/admin/schedule/posting/X where is an id of your choosing.
  2. Check to see the page exists and the id is retrieved correctly.

What should reviewers focus on?

  • Check to see if the page exists. Nothing too tough about this one.

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@hujoseph99 hujoseph99 requested a review from a team March 19, 2022 20:32
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 04081c7):

https://sistering-dev--pr223-joseph-create-admin-r06h99wo.web.app

(expires Sat, 26 Mar 2022 20:36:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

LenaNguyen
LenaNguyen approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@LenaNguyen LenaNguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@hujoseph99 hujoseph99 merged commit 08284d1 into main Mar 21, 2022
@hujoseph99 hujoseph99 deleted the joseph/create-admin-schedule-posting-page branch March 21, 2022 13:34
LenaNguyen pushed a commit that referenced this pull request Mar 24, 2022
@hujoseph99 @LenaNguyen
create AdminSchedulePostingPage placeholder (#223)
ad8b2bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LenaNguyen LenaNguyen LenaNguyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create AdminSchedulePostingPage
2 participants
@hujoseph99 @LenaNguyen