Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RichTextDisplay in posting details page #239

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

Boyazhang1
Copy link
Member

Ticket link

Closes #131

Implementation description

Steps to test

  1. Follow testing instructions in Add Posting Details Page UI and Query #140 , but replace the description field of the createPosting mutation with the following richText samples:
  • "{"blocks":[{"key":"2ggjh","text":"hi","type":"ordered-list-item","depth":0,"inlineStyleRanges":[],"entityRanges":[],"data":{}},{"key":"2nlb2","text":"aewf","type":"ordered-list-item","depth":0,"inlineStyleRanges":[{"offset":0,"length":4,"style":"BOLD"}],"entityRanges":[],"data":{}},{"key":"6a81d","text":"asf","type":"ordered-list-item","depth":0,"inlineStyleRanges":[{"offset":0,"length":3,"style":"BOLD"},{"offset":0,"length":3,"style":"UNDERLINE"}],"entityRanges":[],"data":{}}],"entityMap":{}}"
  • "{"blocks":[{"key":"2ggjh","text":"ajwefiojeio","type":"unordered-list-item","depth":0,"inlineStyleRanges":[],"entityRanges":[],"data":{}},{"key":"80c8b","text":"jasidf","type":"unordered-list-item","depth":0,"inlineStyleRanges":[{"offset":0,"length":6,"style":"BOLD"},{"offset":0,"length":6,"style":"UNDERLINE"},{"offset":0,"length":6,"style":"ITALIC"}],"entityRanges":[],"data":{}},{"key":"4qepd","text":"ajewoifjwejo","type":"unstyled","depth":0,"inlineStyleRanges":[{"offset":0,"length":12,"style":"BOLD"},{"offset":0,"length":12,"style":"UNDERLINE"},{"offset":0,"length":12,"style":"ITALIC"}],"entityRanges":[],"data":{}}],"entityMap":{}}"

Which should display the following
image
image

What should reviewers focus on?

  • Verify the description is displayed properly in richtext

Checklist

  • [x ] My PR name is descriptive and in imperative tense
  • [ x] My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • [x ] I have run the appropriate linter(s)
  • [x ] I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@Boyazhang1 Boyazhang1 changed the title use RichTextDisplay in posting details page Use RichTextDisplay in posting details page Mar 27, 2022
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit ae0fca2):

https://sistering-dev--pr239-boya-display-richtex-xmtuxqs3.web.app

(expires Sun, 03 Apr 2022 20:08:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Member

@sherryhli sherryhli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Boyazhang1 Boyazhang1 merged commit 136c793 into main Mar 29, 2022
@Boyazhang1 Boyazhang1 deleted the boya/display-richtext-posting-details branch March 29, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display rich text in Posting Details
2 participants