Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create GitHub Workflow for Linting #24

Merged
merged 6 commits into from
Oct 16, 2021
Merged

Create GitHub Workflow for Linting #24

merged 6 commits into from
Oct 16, 2021

Conversation

daniel-sm-yu
Copy link
Contributor

@daniel-sm-yu daniel-sm-yu commented Oct 6, 2021 •
edited
Loading

Closes #22

Implementation description

  • create .github/workflows/super-linter.yml to run linter whenever code is pushed to main, PRs are made to main
  • allow linter to be started manually

Steps to test

  1. branch off of daniel/github-action
  2. make a PR with bad formatting
  3. see if linter finds the error

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

sherryhli
sherryhli requested changes Oct 6, 2021
View reviewed changes
Copy link
Member

@sherryhli sherryhli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we run yarn lint directly please? Sorry, I should've specified in the ticket description

@daniel-sm-yu daniel-sm-yu changed the title Create super-linter.yml GitHub Workflow Create GitHub Workflow for Linting Oct 12, 2021
sherryhli
sherryhli approved these changes Oct 16, 2021
View reviewed changes
Copy link
Member

@sherryhli sherryhli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sherryhli sherryhli mentioned this pull request Oct 16, 2021
Closed
4 tasks
@daniel-sm-yu daniel-sm-yu merged commit 3c1777d into main Oct 16, 2021
@daniel-sm-yu daniel-sm-yu deleted the daniel/github-action branch October 16, 2021 21:08
sherryhli added a commit that referenced this pull request Jan 6, 2022
@daniel-sm-yu @sherryhli
Create GitHub Workflow for Linting (#24)
adbcb45 
* Create lint.yml (Github Action)

.

* Fix linter errors

* Lint and format code

* Create lint.yml (Github Action)

.

* Fix linter errors

Co-authored-by: Sherry Li <sherryhli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherryhli sherryhli sherryhli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GitHub Actions for lint and format checks
2 participants
@daniel-sm-yu @sherryhli