-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Posting CRUD Methods and GraphQL Resolvers #64
Conversation
Co-authored-by: Brian Tu <brianptu2@gmail.com>
Co-authored-by: Brian Tu <brianptu2@gmail.com>
Co-authored-by: Brian Tu <brianptu2@gmail.com>
Co-authored-by: Brian Tu <brianptu2@gmail.com>
- fix types - change to implicit relations and migration Co-authored-by: Brian Tu <brianptu2@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far! Will do a second review once this set of comments is addressed
…rian/posting-crud-resolvers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, just a couple of minor things left!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚢
(please coordinate the order of merging with the rest of the team as described in Slack)
Extra nit: can we rename these files to keep consistency with the other interface files?
|
* Modify schema and create types Co-authored-by: Brian Tu <brianptu2@gmail.com> * Finish IPostingService interface Co-authored-by: Brian Tu <brianptu2@gmail.com> * add posting services and resolvers * progress on posting service and types changes * Modify schema and create types Co-authored-by: Brian Tu <brianptu2@gmail.com> * Finish IPostingService interface Co-authored-by: Brian Tu <brianptu2@gmail.com> * add posting services and resolvers * progress on posting service and types changes * finished posting service * posting service changes * Fix postingService errors - fix types - change to implicit relations and migration Co-authored-by: Brian Tu <brianptu2@gmail.com> * added PostingWithRelations type * helper function cleanup * pr review changes * PR review changes part 2 * lint errors * create migration file for unique skill names * Rename interface files for consistency Co-authored-by: Brian Tu <brianptu2@gmail.com>
Ticket link
Closes #50
Implementation description
Steps to test
docker-compose up --build
docker exec -it sistering_backend /bin/bash -c "npx prisma generate"
and run the lastest migration files usingnpx prisma migrate deploy
What should reviewers focus on?
Checklist