-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update languages field to use SearchSelectorField #667
Conversation
@@ -181,6 +181,7 @@ const SearchSelectorField = ({ | |||
if (option.id !== "-1") { // User-added values have an id of "-1" before submitting | |||
onSelect(option.id); | |||
} | |||
setTextboxInput(""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just clears input when a user selects something from the dropdown.
Visit the preview URL for this PR (updated for commit 1237c15): https://sistering-dev--pr667-tejas-update-languag-exofdmlf.web.app (expires Tue, 06 Sep 2022 18:47:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I'll test this out in a bit and approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding this in. Huge UX improvement 😤
Ticket link
Closes #591, #666
Implementation description
Steps to test
What should reviewers focus on?
Checklist