Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create page for Admin Posting #95

Merged
merged 1 commit into from
Jan 23, 2022
Merged

Create page for Admin Posting #95

merged 1 commit into from
Jan 23, 2022

Conversation

MatoPlus
Copy link
Member

@MatoPlus MatoPlus commented Jan 21, 2022 •
edited
Loading

Ticket link

Closes #87

Implementation description

  • Add a page for admin posting (located in frontend/src/components/pages/admin/posting/CreatePostingShiftsPage.tsx). Empty div.
  • PrivateRoute added for new page

Steps to test

  1. route /admin/posting/create/shifts should return 404 when logged in as authenticated user

What should reviewers focus on?

  • Commit msg ok?
  • Right type of route used?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@github-actions
Copy link

github-actions bot commented Jan 21, 2022 •
edited
Loading

Visit the preview URL for this PR (updated for commit f5118e4):

https://sistering-dev--pr95-rickson-admin-postin-mgekkgyh.web.app

(expires Sun, 30 Jan 2022 20:02:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@MatoPlus MatoPlus force-pushed the rickson/admin-posting-page-init branch 2 times, most recently from bc18a8d to a9e633a Compare January 21, 2022 00:57
@MatoPlus MatoPlus marked this pull request as ready for review January 21, 2022 01:00
LenaNguyen
LenaNguyen previously approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@LenaNguyen LenaNguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatoPlus MatoPlus force-pushed the rickson/admin-posting-page-init branch from a9e633a to f5118e4 Compare January 23, 2022 19:58
@MatoPlus MatoPlus marked this pull request as draft January 23, 2022 20:03
@MatoPlus MatoPlus force-pushed the rickson/admin-posting-page-init branch from f5118e4 to a9e633a Compare January 23, 2022 20:04
@MatoPlus MatoPlus force-pushed the rickson/admin-posting-page-init branch from a9e633a to 06d87f7 Compare January 23, 2022 20:07
@MatoPlus MatoPlus marked this pull request as ready for review January 23, 2022 20:07
@MatoPlus MatoPlus merged commit 8108fcc into main Jan 23, 2022
@MatoPlus MatoPlus deleted the rickson/admin-posting-page-init branch January 23, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LenaNguyen LenaNguyen LenaNguyen approved these changes

@sherryhli sherryhli Awaiting requested review from sherryhli

Assignees

@LenaNguyen LenaNguyen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page for Admin Posting
2 participants
@MatoPlus @LenaNguyen