Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/details on upload error #27

Merged
merged 5 commits into from
Oct 17, 2023
Merged

Feature/details on upload error #27

merged 5 commits into from
Oct 17, 2023

Conversation

pbugni
Copy link
Contributor

@pbugni pbugni commented Oct 14, 2023

Need to parse error from response bundle, when upload fails.

Now generating an audit such as:

ERROR:hydrant_event_logger:response: [{'severity': 'error', 'code': 'processing', 'diagnostics': 'Failed to UPDATE resource with match URL "Patient?family=Skywalker&given=Luke&birthdate=1970-04-06" because this search matched 2 resources'}]

@pbugni
Copy link
Contributor Author

pbugni commented Oct 14, 2023

This resolved the outstanding issue found on uwmedicine.stage.cosri.app - turned out to be a quoting whitespace problem with the HAPI upgrade, but good to have enhanced logging for "next time".

mcjustin
mcjustin approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@mcjustin mcjustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me per https://www.pivotaltracker.com/story/show/186028238/comments/238826710

@pbugni pbugni merged commit 583c591 into develop Oct 17, 2023
2 checks passed
@pbugni pbugni deleted the feature/details-on-upload-error branch October 17, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcjustin mcjustin mcjustin approved these changes

@ivan-c ivan-c Awaiting requested review from ivan-c

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbugni @mcjustin