Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oneTBB] Pass range to the parallel_sort algorithm by forwarding reference #380

Conversation

ivankochin
Copy link
Contributor

Passing range by forwarding reference to support std::span and other view containers which may be passed as an rvalue or const, but provide the non-const access to data.

Signed-off-by: Kochin Ivan kochin.ivan@intel.com

…ence

Signed-off-by: Kochin Ivan <kochin.ivan@intel.com>
@ivankochin ivankochin changed the title oneTBB: Pass range to the parallel_sort algorithm by forwarding reference [oneTBB] Pass range to the parallel_sort algorithm by forwarding reference Oct 11, 2021
@ivankochin ivankochin self-assigned this Oct 11, 2021
@ivankochin ivankochin marked this pull request as draft October 11, 2021 09:04
@kboyarinov
Copy link
Contributor

I am OK with the change, but as for me, one more minor fix is required. Iterators of parallel_sort should meet the requirements of ValueSwappable instead of Swappable. Could you please clarify the standard section for ValueSwappable add it to the patch.

@ivankochin ivankochin marked this pull request as ready for review October 28, 2021 07:01
@ivankochin ivankochin merged commit 6f04959 into uxlfoundation:main Oct 28, 2021
@ivankochin ivankochin deleted the parallel-sort-get-range-by-forwarding-reference branch October 28, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants