-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[oneMKL] Add BLAS APIs #383
Conversation
3c2ede7
to
91f0a87
Compare
@aaronjohnson Maybe I missed it, but i did not see the changes needed for gemm_bias and trsm_batch. Please let me know if I missed them. Edit: My mistake, no edits are needed for trsm_batch and gemm_bias. Could you please remove the unnecessary copies of exceptions in trsm_batch? |
The queue where the routine should be executed. | ||
|
||
upper_lower | ||
Array of group_count onemkl::upper_lower |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
group_count
onemkl::upper_lower
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put these inside ticks pls. Looks at the other parameters for reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adjusted
upper_lower | ||
Array of group_count onemkl::upper_lower | ||
values. ``upper_lower[i]`` specifies whether data in C for every | ||
matrix in group ``i`` is in upper or lower triangle form. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove "form"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adjusted
@rscohn2 this is the PR I have been talking with you about. They are going to clean up the commit message and we will merge it early this morning. |
I've rebase+squashed all the commits on the PR into one. |
Adding BLAS APIs now in oneMKL product to the specification.