[oneDPL] Clarify the version of the C++ standard for the oneDPL spec #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akukanov
changed the title
akukanov
changed the title
rarutyun
reviewed
Sep 11, 2023
| @@ -5,7 +5,8 @@ | |||
| Parallel API | |||
| ------------ | |||
|
|
|||
| oneDPL provides the set of algorithms with execution policies as defined by the `C++ Standard`_. | |||
| oneDPL provides the set of parallel algorithms as defined by the `C++ Standard`_, | |||
| including parallel algorithms added in the 6th edition known as C++20. | |||
There was a problem hiding this comment.
Do we want to say
Suggested change
| including parallel algorithms added in the 6th edition known as C++20. | |
| including parallel algorithms added in the International Standard ISO/IEC 14882:2020 known as C++20. |
?
There was a problem hiding this comment.
According to https://www.iso.org/standard/79358.html, C++20 is the 6th edition of the standard. Since a reference to the standard is already given in this sentence, I think it's quite clear what "the 6th edition" refers to.
I can do this change here, but then the other mentioning of the 6th edition below will look less clear.
timmiesmith
reviewed
Sep 11, 2023
| @@ -5,7 +5,8 @@ | |||
| Parallel API | |||
| ------------ | |||
|
|
|||
| oneDPL provides the set of algorithms with execution policies as defined by the `C++ Standard`_. | |||
| oneDPL provides the set of parallel algorithms as defined by the `C++ Standard`_, | |||
| including parallel algorithms added in the 6th edition known as C++20. | |||
aepanchi
pushed a commit
to aepanchi/oneAPI-spec
that referenced
this pull request
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly say that the base C++ standard version is C++17, but the parallel API also implements algorithms & policies from C++20