[oneMKL][BLAS] value_or_pointer wrapper for BLAS USM scalar parameters #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmeterel
reviewed
Sep 22, 2023
| ``value_or_pointer<T>`` wrapper to enable either pointers or values | ||
| to be passed to routines that take a scalar parameter. This type is in | ||
| the ``oneapi::mkl::`` namespace and defined in the header file | ||
| ``oneapi/mkl/types.hpp``. |
There was a problem hiding this comment.
This seems to be too specific to oneMKL product. For spec, should we consider removing this or make it more general?
There was a problem hiding this comment.
Agreed, I've removed that sentence.
mmeterel
approved these changes
Sep 22, 2023
aepanchi
pushed a commit
to aepanchi/oneAPI-spec
that referenced
this pull request
Oct 31, 2023
uxlfoundation#503) * [oneMKL][BLAS] value_or_pointer wrapper for BLAS UUSM scalar parameters
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow either values or pointers for scalar parameters to BLAS functions with USM interfaces.
This would allow users to provide values in device memory for these scalar parameters.