Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[oneDPL] Create a subsection for is_execution_policy type trait #567
[oneDPL] Create a subsection for is_execution_policy type trait #567
Changes from 10 commits
ff342a7
d8f05eb
fa0f037
7138a94
dab98a2
7f4f416
b8a777b
f3b68a0
0c955d7
c4a053f
eb5b844
ff844ac
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer that order because this is the way it's defined in C++ standard. I don't want to hold this PR because of that issue but if you decide to change it the way I am suggesting, please ping me and I approve this patch once again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, I will do it. No re-approval is needed, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spellcheckers do not complain :), so I will keep this intact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, this is small suggestion. As far as I understand "preposition + which" is consider to be poorer English. More common use is "bla-bla, which + <proposition at the end>. Again, not proposing to change that but for my curiosity we could summon a native speaker. @danhoeflinger, could you please share your opinion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I searched for clarification on this, and I have found that "preposition + which" is considered not poorer but more formal English.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that "in which" is more formal (but a bit awkward), and "which ... in" is less formal, and a "dangling preposition" https://www.thefreedictionary.com/Dangling-Prepositions.htm which is a classic English grammar issue.
I was trying to rephrase to avoid the problem, but I think it may make it less clear.
"The location of the underlying class template definition and its specializations is left unspecified."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another option, avoiding the preposition:
"It is unspecified, which namespace contains the underlying class template definition and its specializations."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Dan, I like the last suggestion, will apply it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also like that.
Thanks for clarification