feature: dynamic setting deps layouts #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/intelci: run |
Alexandr-Solovev
requested review from
samir-nasibli,
napetrov,
ahuber21 and
ethanglaser
as code owners
napetrov
reviewed
Oct 2, 2024
| @@ -214,15 +214,17 @@ TBBDIR.include := $(if $(TBBDIR.2),$(TBBDIR.2)/include/tbb $(TBBDIR.2)/include) | |||
|
|
|||
| TBBDIR.libia.prefix := $(TBBDIR.2)/lib | |||
|
|
|||
| ifeq ($(MKL_FPK_GPU_VERSION_LINE),2024.0.0) | |||
| OLD_TBB_LAYOUT := $(if $(wildcard $(call frompf1,$(TBBDIR.libia.prefix))/$(_IA)),yes,no) | |||
There was a problem hiding this comment.
do we need to support old tbb layout?
There was a problem hiding this comment.
Is it possible scenario that user will try to use tbb with old layout in build? I guess that just since 2021.12 or 13 new layout exists, it makes sense to support old layout, but not sure
homksei
approved these changes
Oct 7, 2024
|
/intelci: run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add dynamic checker for TBB layout
Testing