Atomic class definition redundant #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. |
|
Ethanlm, change base for your commit to 01org:daal_2017_update1 resulted in lost history between commits. I will recommit it separately to daal_2017_update1. Thank you. |
amgrigoriev
referenced
this pull request
in amgrigoriev/daal
Mar 26, 2020
amgrigoriev
referenced
this pull request
in amgrigoriev/daal
Mar 26, 2020
vlad-nazarov
pushed a commit
that referenced
this pull request
Mar 27, 2020
amgrigoriev
referenced
this pull request
in amgrigoriev/daal
Mar 29, 2020
amgrigoriev
referenced
this pull request
in amgrigoriev/daal
Mar 29, 2020
dr-pain
pushed a commit
to dr-pain/daal
that referenced
this pull request
Apr 20, 2020
dr-pain
pushed a commit
to dr-pain/daal
that referenced
this pull request
Apr 21, 2020
amgrigoriev
referenced
this pull request
in amgrigoriev/daal
Oct 11, 2020
averbukh
pushed a commit
to averbukh/oneDAL
that referenced
this pull request
Apr 23, 2021
Allocation via virtual functions
averbukh
pushed a commit
to averbukh/oneDAL
that referenced
this pull request
Jun 2, 2021
averbukh
pushed a commit
that referenced
this pull request
Jun 3, 2021
* Experiment to address infinite loop * Experiment #2 to address infinite loop * Experiment #3 to address infinite loop * Temporary debug output added * External limit for number of threads was removed * Experiment #4 to address infinite loop * Experiment #5 to address infinite loop * Experiment #6 to address infinite loop * Experiment #7 to address infinite loop * Experiment #8 to address infinite loop * 20% is set as optimal value * Temporary code removed * Optimal array_size is caclulated based on max thread count * Optimal array_size is decreased * Optimal array_size is adjusted * Optimal array_size is adjusted * Optimal array_size is adjusted * Optimal array_size is adjusted * Optimal array_size is adjusted * Optimal array_size is adjusted * Optimal array_size is adjusted * Experiment #9 to address infinite loop * Optimal array_size is adjusted * Temporary debug output added * Compilation fix * Experiment #10 to address infinite loop * Temporary debug output added * Experiment #11 to address infinite loop * Temporary code removed * Optimal array_size is adjusted
averbukh
pushed a commit
that referenced
this pull request
Jun 3, 2021
* Experiment to address infinite loop * Experiment #2 to address infinite loop * Experiment #3 to address infinite loop * Temporary debug output added * External limit for number of threads was removed * Experiment #4 to address infinite loop * Experiment #5 to address infinite loop * Experiment #6 to address infinite loop * Experiment #7 to address infinite loop * Experiment #8 to address infinite loop * 20% is set as optimal value * Temporary code removed * Optimal array_size is caclulated based on max thread count * Optimal array_size is decreased * Optimal array_size is adjusted * Optimal array_size is adjusted * Optimal array_size is adjusted * Optimal array_size is adjusted * Optimal array_size is adjusted * Optimal array_size is adjusted * Optimal array_size is adjusted * Experiment #9 to address infinite loop * Optimal array_size is adjusted * Temporary debug output added * Compilation fix * Experiment #10 to address infinite loop * Temporary debug output added * Experiment #11 to address infinite loop * Temporary code removed * Optimal array_size is adjusted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In include/services/daal_atomic_int.h, the Atomic definition is redundant. And also the return type of inc() and dec() should be dataType instead of int