Sarathna/cmplropts

[sarathnandu]

Description

Add compiler flags to prevent compiler from optimizing out security checks.

Fixes # - issue number(s) if exists

• - git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

• bug fix - change that fixes an issue
• new feature - change that adds functionality
• tests - change in tests
• infrastructure - change in infrastructure and CI
• documentation - documentation update

Tests

• added - required for new features and some bug fixes
• [x ] not needed

Documentation

• updated in # - add PR number
• needs to be updated
• [x ] not needed

Breaks backward compatibility

• Yes
• [x ] No
• Unknown

Notify the following users

List users with @ to send notifications

Other information

[phprus]

Tell me please, why only for GCC?
Won't adding these flags mask undefined behavior errors in oneTBB?

[sarathnandu]

The flags added in this patch
-fno-strict-overflow tells the compiler NOT to assume that signed overflow does not occur.
-fno-delete-null-pointer-checks tells the compiler NOT to assume that null pointer deference does not exist.
-fwrapv tells the compiler that signed overflow always wraps.
So i believe it restrict the compiler from making arbitrary decisions while handling undefined C/C++ behaviors.

AIUI they are not supported in Clang or msvc. By adding it in Gnu.cmake it gets included in Intel.cmake as well. If I found similar flags for clang version, I would like to add for Clang too.

[omalyshe]

@sarathnandu Please fix the copyright year to 2020-2023