Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically create a PR with fixes when lint problems are detected on master #4322

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

Etheryte
Copy link
Member

@Etheryte Etheryte commented Oct 8, 2021

What does this PR change?

With the introduction of more uniform frontend code formatting the linter now checks for automatically fixable style issues as well. This has already been incorporated into the PR actions workflow but we might still run into issues during branch lock time. I wouldn't expect us to run into this case often, but this is a nice sanity check to have as a backup.

This new action runs whenever there's pushes to master, locked or not, and creates a PR with automatic lint fixes when problems are detected. You can see an example PR on my fork here.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: new GH action

  • DONE

Links

Followup for https://github.com/SUSE/spacewalk/issues/13437
Blocked by #4298

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_oracle"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Copy link
Contributor

@ncounter ncounter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@Etheryte Etheryte merged commit 778725c into uyuni-project:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants