Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/frontend-manage): ensure correct application of multipliers #3855

Merged
merged 6 commits into from
Sep 20, 2023

Conversation

sjschlapbach
Copy link
Member

This pull request fixes an issue where wrong available point values were shown on different elements and also introduces additional information on the micro session overview page (see screenshots).

Screenshot 2023-09-20 at 12 32 38
Screenshot 2023-09-20 at 11 12 51

@cypress
Copy link

cypress bot commented Sep 20, 2023

3 failed and 4 flaky tests on run #883 ↗︎

3 14 0 0 Flakiness 4

Details:

Merge 2443c23 into 55f6ac5...
Project: klicker-uzh Commit: c4eb0165b0 ℹ️
Status: Failed Duration: 04:28 💡
Started: Sep 20, 2023 1:55 PM Ended: Sep 20, 2023 1:59 PM
Failed  live-session-workflow.cy.ts • 1 failed test

View Output Video

Test Artifacts
Different live-session workflows > shows a possible workflow of running a session and answering questions Test Replay Output Screenshots
Failed  questions-workflow.cy.ts • 2 failed tests

View Output Video

Test Artifacts
Create questions > creates a Free Text question Screenshots
Create questions > creates a new question, duplicates it and then deletes the duplicate again Screenshots
Flakiness  live-session-workflow.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Different live-session workflows > creates a session with one block Test Replay Output Screenshots
Flakiness  micro-session-workflow.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
Different micro-session workflows > creates and publishes a future micro session that should not be visible to students Test Replay Output Screenshots
Different micro-session workflows > creates and publishes a past micro session that should not be visible to students Test Replay Output Screenshots
Flakiness  questions-workflow.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Create questions > creates a KPRIM question Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@sjschlapbach
Copy link
Member Author

TODO: change date format on micro session preview to standard CH-format (with dots instead of slashes). Possibly a standard dayjs formatting can be used for this.

@sjschlapbach sjschlapbach marked this pull request as draft September 20, 2023 13:49
@rschlaefli rschlaefli marked this pull request as ready for review September 20, 2023 14:56
@rschlaefli rschlaefli merged commit bf56f0f into v3 Sep 20, 2023
5 of 8 checks passed
@rschlaefli rschlaefli deleted the FixMultiplierIssues branch September 20, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants