Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add deletion confirmation steps to live quiz abortion process #4293

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

sjschlapbach
Copy link
Member

@sjschlapbach sjschlapbach commented Oct 4, 2024

Screenshot 2024-10-04 at 17 21 12

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced a new SessionAbortionConfirmations component for managing user confirmations related to live quiz deletions.
    • Added a GraphQL query GetLiveQuizSummary to retrieve key metrics for live quizzes.
  • Improvements

    • Enhanced the CancelSessionModal to fetch live quiz data and simplify user confirmation processes.
    • Updated localization files for improved clarity and user experience in both German and English.
  • Bug Fixes

    • Minor adjustments to component styling and prop handling for consistency and clarity.
  • Tests

    • Expanded Cypress end-to-end tests for live quiz workflows, ensuring robust session management and feedback handling.

Copy link

aviator-app bot commented Oct 4, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link

coderabbitai bot commented Oct 4, 2024

📝 Walkthrough

Walkthrough

The pull request introduces several changes across multiple components in the frontend application. Key modifications include renaming the CourseDeletionItem component to DeletionItem, updating related imports, and enhancing the CancelSessionModal to include live quiz data fetching. A new component, SessionAbortionConfirmations, is added to manage user confirmations for deletions during live quizzes. GraphQL queries and schema are updated to support these functionalities, including the introduction of a GetLiveQuizSummary query. Localization files are also updated to reflect new user interface strings.

Changes

File Change Summary
apps/frontend-manage/src/components/common/DeletionItem.tsx Renamed CourseDeletionItem to DeletionItem, updated export statement, and modified outer div class name for styling.
apps/frontend-manage/src/components/courses/modals/CourseDeletionConfirmations.tsx Replaced CourseDeletionItem import with DeletionItem, maintaining the same props structure.
apps/frontend-manage/src/components/sessions/cockpit/CancelSessionModal.tsx Added useQuery hook for live quiz data fetching, updated modal props for visibility management, and simplified user interaction for session cancellation confirmations.
apps/frontend-manage/src/components/sessions/cockpit/SessionAbortionConfirmations.tsx Introduced new component for managing deletion confirmations related to live quizzes, utilizing DeletionItem for individual deletion options.
apps/frontend-manage/src/components/sessions/cockpit/SessionTimeline.tsx Updated props for CancelSessionModal from isCancellationModalOpen to open and setIsCancellationModalOpen to setOpen.
apps/frontend-manage/src/pages/sessions/[id]/cockpit.tsx Removed commented-out code related to session management, focusing on core functionality.
cypress/cypress/e2e/F-live-quiz-workflow.cy.ts Added new test case for live quiz workflows, including session creation, management, and feedback handling.
packages/graphql/src/graphql/ops/QGetLiveQuizSummary.graphql Introduced new query GetLiveQuizSummary to retrieve live quiz metrics based on quizId.
packages/graphql/src/ops.schema.json Updated schema to include new query getLiveQuizSummary and new object RunningLiveQuizSummary with relevant fields.
packages/graphql/src/ops.ts Added new scalar types and numerous new types related to quiz and session management.
packages/graphql/src/public/client.json Added method GetLiveQuizSummary to the public GraphQL client.
packages/graphql/src/public/schema.graphql Introduced new type RunningLiveQuizSummary and updated Query type with getLiveQuizSummary.
packages/graphql/src/public/server.json Added query GetLiveQuizSummary and updated GetSingleCourse to include numOfActiveParticipants.
packages/graphql/src/schema/query.ts Added method getLiveQuizSummary in the query schema and updated import statements.
packages/graphql/src/schema/session.ts Defined new interface IRunningLiveQuizSummary and its implementation.
packages/graphql/src/services/sessions.ts Introduced asynchronous function getLiveQuizSummary to retrieve live quiz data.
packages/i18n/messages/de.ts Updated German localization file with new keys and modified existing translations.
packages/i18n/messages/en.ts Updated English localization file with new strings and modifications to existing ones for clarity.

Possibly related PRs

Suggested reviewers

  • rschlaefli: Suggested for review due to familiarity with the components and changes made in this pull request.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

sonarqubecloud bot commented Oct 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
11.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

cypress bot commented Oct 4, 2024

klicker-uzh    Run #3138

Run Properties:  status check failed Failed #3138  •  git commit 08c72d3243 ℹ️: Merge cc21db48e6fade13ccbb1fb809873f41d47348bf into 8ca6946ae0ef5af97cf522352e47...
Project klicker-uzh
Branch Review enhanced-cancel-session-modal
Run status status check failed Failed #3138
Run duration 09m 56s
Commit git commit 08c72d3243 ℹ️: Merge cc21db48e6fade13ccbb1fb809873f41d47348bf into 8ca6946ae0ef5af97cf522352e47...
Committer Julius Schlapbach
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 46
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/E-course-workflow.cy.ts • 1 failed test

View Output

Test Artifacts
Test course creation and editing functionalities > Test the assignment of random groups in the seeded test course Test Replay Screenshots
Flakiness  cypress/e2e/K-group-activity-workflow.cy.ts • 1 flaky test

View Output

Test Artifacts
Create and solve a group activity > create a group activity and edit it Screenshots

@sjschlapbach sjschlapbach merged commit 26af2c8 into v3 Oct 4, 2024
8 of 14 checks passed
@sjschlapbach sjschlapbach deleted the enhanced-cancel-session-modal branch October 4, 2024 18:03
Copy link

cypress bot commented Oct 4, 2024

klicker-uzh    Run #3139

Run Properties:  status check passed Passed #3139  •  git commit 26af2c85f1: enhance: add deletion confirmation steps to live quiz abortion process (#4293)
Project klicker-uzh
Branch Review v3
Run status status check passed Passed #3139
Run duration 09m 34s
Commit git commit 26af2c85f1: enhance: add deletion confirmation steps to live quiz abortion process (#4293)
Committer Julius Schlapbach
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 47
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant