-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: add deletion confirmation steps to live quiz abortion process #4293
Conversation
…ced-cancel-session-modal
Current Aviator status
This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
📝 WalkthroughWalkthroughThe pull request introduces several changes across multiple components in the frontend application. Key modifications include renaming the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Quality Gate failedFailed conditions |
klicker-uzh Run #3138
Run Properties:
|
Project |
klicker-uzh
|
Branch Review |
enhanced-cancel-session-modal
|
Run status |
Failed #3138
|
Run duration | 09m 56s |
Commit |
08c72d3243 ℹ️: Merge cc21db48e6fade13ccbb1fb809873f41d47348bf into 8ca6946ae0ef5af97cf522352e47...
|
Committer | Julius Schlapbach |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
46
|
View all changes introduced in this branch ↗︎ |
Tests for review
cypress/e2e/E-course-workflow.cy.ts • 1 failed test
Test | Artifacts | |
---|---|---|
Test course creation and editing functionalities > Test the assignment of random groups in the seeded test course |
Test Replay
Screenshots
|
cypress/e2e/K-group-activity-workflow.cy.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
Create and solve a group activity > create a group activity and edit it |
Screenshots
|
klicker-uzh Run #3139
Run Properties:
|
Project |
klicker-uzh
|
Branch Review |
v3
|
Run status |
Passed #3139
|
Run duration | 09m 34s |
Commit |
26af2c85f1: enhance: add deletion confirmation steps to live quiz abortion process (#4293)
|
Committer | Julius Schlapbach |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
47
|
View all changes introduced in this branch ↗︎ |
Summary by CodeRabbit
Release Notes
New Features
SessionAbortionConfirmations
component for managing user confirmations related to live quiz deletions.GetLiveQuizSummary
to retrieve key metrics for live quizzes.Improvements
CancelSessionModal
to fetch live quiz data and simplify user confirmation processes.Bug Fixes
Tests