Merge with master #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was noticed in Cursor.columns, but I'm sure it affects a couple of other places in the code. Unfortunately the solution is hideously inefficient. I tried not null terminating, but I'm afraid driver differences when not using SQLWCHAR, such as drivers that want UTF8, will cause non-stop errors. Suggestions for a more efficient implementation are welcome. Alternatively, if someone wants to try converting to using lengths instead of null terminated strings *and* testing it, I'd be interested.
* Update int parameter binding to use 'int' instead of 'bigint' when possible for drivers that don't support bigint like Access. If most values are small, should save networking traffic also. * Update Python 2 Access GUID test to expect Unicode. * Update access tests to manage the test files themselves. * Python 2 access test now encodes all strings at UTF-16.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.