Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix installation of incorrect docker version #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix installation of incorrect docker version #11

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e22c0ee
Fixed installation of incorrect docker version by using rancher insta…
slarimore02 Nov 22, 2017
bb90beb
fixed docker installation for node-add script
slarimore02 Nov 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion deploy-node/node-add
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ EOF

### NEW INSTALLATIONS:
echo_green "\nPhase I: Installing system prerequisites:"
pkg="build-essential curl docker.io ethtool git lldpd socat traceroute vim ceph-common nfs-common"
pkg="build-essential curl ethtool git lldpd socat traceroute vim ceph-common nfs-common"

for pkg in ${pkg}; do
if sudo dpkg --get-selections | grep -q "^${pkg}[[:space:]]*install$" >/dev/null; then
Expand All @@ -53,6 +53,8 @@ for pkg in ${pkg}; do
fi
done

curl https://raw.githubusercontent.com/rancher/install-docker/master/1.12.6.sh | bash
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to put this into a conditional rather than issuing a reinstall each time. according to dockers documentation (and i've experienced this first hand) reinstalling without removal first can cause some really strange issues. other than that, good find.

we could actually take this script, own it, and add the conditional to the script. i don't typically like own things, but in this case, it could prevent issues in the case where they pull the script for some reason.



### PREPARE: /etc/resolv.conf
echo_green "\nPhase III: Preparing system DNS:"
Expand Down