Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] Pascalvoc importer should not fail on float values #177

Merged
merged 5 commits into from
Aug 3, 2021

Conversation

andreaazzini
Copy link
Member

Addresses #137

Copy link
Contributor

@Fl4m3Ph03n1x Fl4m3Ph03n1x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests!
Some minor questions and a suggestion for a change.

darwin/importer/formats/pascalvoc.py Outdated Show resolved Hide resolved
darwin/importer/formats/pascalvoc.py Show resolved Hide resolved
darwin/importer/importer.py Show resolved Hide resolved
@Fl4m3Ph03n1x
Copy link
Contributor

Approved !

@simedw simedw merged commit a184870 into master Aug 3, 2021
FrancescoSaverioZuppichini pushed a commit that referenced this pull request Aug 20, 2021
* Remove unused packages

* Fix bug with float values in pascalvoc importer

* Add tests

* Changes from feedback
@owencjones owencjones deleted the hotfix/pascalvoc-importer branch December 2, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants