-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SWAT-735][internal] Added nifti to supported formats. #530
Merged
owencjones
merged 1 commit into
master
from
swat-735-nifti-export-fails-for-several-teams
Feb 7, 2023
Merged
[SWAT-735][internal] Added nifti to supported formats. #530
owencjones
merged 1 commit into
master
from
swat-735-nifti-export-fails-for-several-teams
Feb 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWAT-735 NIFTI export fails for several teams
|
Fl4m3Ph03n1x
requested review from
owencjones,
a team and
elpikel
and removed request for
a team
February 6, 2023 11:52
brain-geek
approved these changes
Feb 6, 2023
elpikel
approved these changes
Feb 7, 2023
owencjones
changed the title
Added nifti to supported formats.
[SWAT-735][internal] Added nifti to supported formats.
Feb 7, 2023
owencjones
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Will liaise with QA to merge.
owencjones
suggested changes
Feb 7, 2023
Put as changes requested, but actually just need to know whether you've considered the docs link. |
Cancelled as not required. |
Reopened as needed |
balysv
added a commit
that referenced
this pull request
Feb 24, 2023
…mports * master: including release in dataset (#534) [IO-749][external] Added python support install on 3.7 (#540) Io 585 incorrect type annotation (#537) [IO-543][internal] Move Imports To Multiprocessing (#521) Version bump to 0.8.12 HOTFIX: Version for unincluded file (#533) [IO-683][internal] Fix version parsing (#532) [SWAT-753][external]: Fix a 'darwin convert' to mask formats path issue (#531) Added nifti to supported formats. (#530) [IO-665][internal] Type fixes (#529) Allow passing a Client to get_dataset() to avoid authentication errors if environment variable isn't set or there is no config. (#522) Version bump to 0.8.11 Version bump (#528) [SWAT-734][Internal] Fixing conversion to darwin_json_1.0 (#523) Version_bump_v0.8.9 (#527) Updating docs for release process (#525) [io-524][internal] Fix for windows builds [SWAT-716][internal]: Fix .json extension parsing for dataset splitting (#520) [IO-557][internal] Move to use Poetry for packaging and publishing (#512)
balysv
added a commit
that referenced
this pull request
Feb 24, 2023
…mports * master: including release in dataset (#534) [IO-749][external] Added python support install on 3.7 (#540) Io 585 incorrect type annotation (#537) [IO-543][internal] Move Imports To Multiprocessing (#521) Version bump to 0.8.12 HOTFIX: Version for unincluded file (#533) [IO-683][internal] Fix version parsing (#532) [SWAT-753][external]: Fix a 'darwin convert' to mask formats path issue (#531) Added nifti to supported formats. (#530) [IO-665][internal] Type fixes (#529) Allow passing a Client to get_dataset() to avoid authentication errors if environment variable isn't set or there is no config. (#522) Version bump to 0.8.11 Version bump (#528) [SWAT-734][Internal] Fixing conversion to darwin_json_1.0 (#523) Version_bump_v0.8.9 (#527) Updating docs for release process (#525) [io-524][internal] Fix for windows builds [SWAT-716][internal]: Fix .json extension parsing for dataset splitting (#520) [IO-557][internal] Move to use Poetry for packaging and publishing (#512)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are missing nifti in error message of supported formats:
Solution
Add nifti to list