Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SWAT-735][internal] Added nifti to supported formats. #530

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

Fl4m3Ph03n1x
Copy link
Contributor

Problem

We are missing nifti in error message of supported formats:

$ darwin convert asd /home/pedro/Downloads/v7-support-test-1675683152 /home/pedro/Downloads/output 
asd
Error: Unsupported export format, currently supported: ['coco', 'cvat', 'dataloop', 'darwin_1.0', 'instance_mask', 'pascalvoc', 'semantic_mask', 'semantic_mask_grey', 'semantic_mask_index', 'yolo']

Solution

Add nifti to list

@linear
Copy link

linear bot commented Feb 6, 2023

SWAT-735 NIFTI export fails for several teams

  1. Seg 3D on this dataset (EDU User): Using WebUI on V2 to export Nifti format
  2. Finnos on this dataset: Using WebUI on V2 to export Darwin JSON 2.0 format (logs show they tried to export to Nifti)

@Fl4m3Ph03n1x Fl4m3Ph03n1x self-assigned this Feb 6, 2023
@Fl4m3Ph03n1x Fl4m3Ph03n1x requested review from owencjones, a team and elpikel and removed request for a team February 6, 2023 11:52
@owencjones owencjones changed the title Added nifti to supported formats. [SWAT-735][internal] Added nifti to supported formats. Feb 7, 2023
Copy link
Contributor

@owencjones owencjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Will liaise with QA to merge.

@owencjones
Copy link
Contributor

Put as changes requested, but actually just need to know whether you've considered the docs link.

@owencjones
Copy link
Contributor

Cancelled as not required.

@owencjones owencjones closed this Feb 7, 2023
@owencjones owencjones deleted the swat-735-nifti-export-fails-for-several-teams branch February 7, 2023 11:17
@owencjones owencjones restored the swat-735-nifti-export-fails-for-several-teams branch February 7, 2023 11:20
@owencjones owencjones reopened this Feb 7, 2023
@owencjones
Copy link
Contributor

owencjones commented Feb 7, 2023

Reopened as needed

@owencjones owencjones merged commit 22a8556 into master Feb 7, 2023
balysv added a commit that referenced this pull request Feb 24, 2023
…mports

* master:
  including release in dataset (#534)
  [IO-749][external] Added python support install on 3.7 (#540)
  Io 585 incorrect type annotation (#537)
  [IO-543][internal] Move Imports To Multiprocessing (#521)
  Version bump to 0.8.12
  HOTFIX: Version for unincluded file (#533)
  [IO-683][internal] Fix version parsing (#532)
  [SWAT-753][external]: Fix a 'darwin convert' to mask formats path issue (#531)
  Added nifti to supported formats. (#530)
  [IO-665][internal] Type fixes (#529)
  Allow passing a Client to get_dataset() to avoid authentication errors if environment variable isn't set or there is no config. (#522)
  Version bump to 0.8.11
  Version bump (#528)
  [SWAT-734][Internal] Fixing conversion to darwin_json_1.0 (#523)
  Version_bump_v0.8.9 (#527)
  Updating docs for release process (#525)
  [io-524][internal] Fix for windows builds
  [SWAT-716][internal]: Fix .json extension parsing for dataset splitting (#520)
  [IO-557][internal] Move to use Poetry for packaging and publishing (#512)
balysv added a commit that referenced this pull request Feb 24, 2023
…mports

* master:
  including release in dataset (#534)
  [IO-749][external] Added python support install on 3.7 (#540)
  Io 585 incorrect type annotation (#537)
  [IO-543][internal] Move Imports To Multiprocessing (#521)
  Version bump to 0.8.12
  HOTFIX: Version for unincluded file (#533)
  [IO-683][internal] Fix version parsing (#532)
  [SWAT-753][external]: Fix a 'darwin convert' to mask formats path issue (#531)
  Added nifti to supported formats. (#530)
  [IO-665][internal] Type fixes (#529)
  Allow passing a Client to get_dataset() to avoid authentication errors if environment variable isn't set or there is no config. (#522)
  Version bump to 0.8.11
  Version bump (#528)
  [SWAT-734][Internal] Fixing conversion to darwin_json_1.0 (#523)
  Version_bump_v0.8.9 (#527)
  Updating docs for release process (#525)
  [io-524][internal] Fix for windows builds
  [SWAT-716][internal]: Fix .json extension parsing for dataset splitting (#520)
  [IO-557][internal] Move to use Poetry for packaging and publishing (#512)
@Nathanjp91 Nathanjp91 deleted the swat-735-nifti-export-fails-for-several-teams branch November 8, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants