Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IO-1081 ]fix for dot/period/. in filename #611

Merged
merged 1 commit into from
Jun 5, 2023
Merged

[IO-1081 ]fix for dot/period/. in filename #611

merged 1 commit into from
Jun 5, 2023

Conversation

Nathanjp91
Copy link
Contributor

dots/periods in filenames cause the last 'segment' between the periods to be lost, and thus causing issues with filenames being downloaded/named incorrectly. This stems from issues with the .with_suffix() function. Replaced with stem + suffix solution that generates the correct filename

Changelog

filenames with multiple dots now saving filenames correctly

@linear
Copy link

linear bot commented May 31, 2023

IO-1081 BUG: Pulling a release with CLI on darwin-py 0.8.22 and 0.8.23 truncates image file names and downloads just a part of all images

BUG submission from: Assem Kozhekova
Summary (describe an issue):
Pulling a release with CLI on darwin-py 0.8.22 and 0.8.23 truncates image file names and downloads just a part of all images.

FROM THE CUSTOMER:
"The dataset pull with darwin-py CLI is broken. There are 1831 annotated images in a dataset export. But only 931 are downloaded. All annotation files are downloaded correctly. But some of png images filenames are truncated."

I was able to reproduce on 0.8.23 myself but it worked correctly as expected on 0.8.19.

0.8.23: 931/1831 images pulled, filenames truncated
0.8.19: 18/1831 images pulled, filenames in full

image.png

image.png

Share Loom/Screenshots with Console/Network opened:
Attached to the Linear ticket
Darwin affected version
V2
Environment (production/staging; browser and OS version)
darwin-py 0.8.23, 0.8.22
Impact
Single (only 1 customer is impacted)
Priority
🟠 High - important issue, but has workaround
Steps to reproduce
Log in to the customer's team and pull all completed files (images + annotations) from the "bs-main-other" dataset.

darwin dataset pull finnos/bs-main-other:support-test
Expected Behaviour
All 1813 images are pulled with their original full filenames
Team & Dataset Link
Finnos https://darwin.v7labs.com/super_admin/teams/2136
Intercom ticket
https://app.intercom.com/a/inbox/pb9z3asr/inbox/admin/5471713/conversation/204470?view=List

@Nathanjp91 Nathanjp91 changed the title [IO-1081 ]fix for dots in filename [IO-1081 ]fix for dot/period/. in filename May 31, 2023
@Nathanjp91 Nathanjp91 requested a review from rslota May 31, 2023 16:10
@nrudakov
Copy link

nrudakov commented Jun 1, 2023

@Nathanjp91 maybe it worth also to get rid of unnecessary str to Path to str conversion on the same line

@PaulWhiteQA
Copy link

QA Pass - Happy with the file formats when pulling with Darwin cli

@Nathanjp91 Nathanjp91 merged commit eb843f7 into master Jun 5, 2023
@Nathanjp91 Nathanjp91 deleted the IO-1081 branch November 8, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants