Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IO-1230] Fix and test for complex polygons #613

Merged
merged 1 commit into from
Jun 7, 2023
Merged

[IO-1230] Fix and test for complex polygons #613

merged 1 commit into from
Jun 7, 2023

Conversation

Nathanjp91
Copy link
Contributor

Problem

Latest fix for semantic mask didn't account for the problem of having complex polygons vs simple polygons

Solution

Polygon offsets now account for complex polygons and deal with simple/complex accordingly

Changelog

Fixed a problem with new semantic mask export logic not accounting for complex polygon datasets with out of bounds polygons. It should now handle complex polygons.

@linear
Copy link

linear bot commented Jun 7, 2023

IO-1230 Complex Polygon offsets in semantic masks

IO-1203 BUG: the fetch_remote_files() method in darwin.client incorrectly returns null for 3 parameters

BUG submission from: John Wilkie
Summary (describe an issue):
the fetch_remote_files() method in darwin.client incorrectly returns null for 3 parameters:

  • dataset_slug
  • current_workflow_Id
  • current_workflow
    Share Loom/Screenshots with Console/Network opened:
    N/A
    Darwin affected version
    V2
    Environment (production/staging; browser and OS version)

Impact
All (all Darwin users are impacted)
Priority
🟠 High - important issue, but has workaround
Steps to reproduce
Run the below Python script for any remote dataset with items in a workflow and observe the above described problem

from darwin.dataset.remote_dataset_v2 import RemoteDatasetV2
from darwin.client import Client

client = Client.from_api_key('ApiKey')
dataset = RemoteDatasetV2(client=client, team='team_slug', dataset_id=dataset_id, name='dataset_name', slug='dataset_slug')
items = [i for i in dataset.fetch_remote_files()]
print(items)
Expected Behaviour

Team & Dataset Link

Intercom ticket
https://app.intercom.com/a/inbox/pb9z3asr/inbox/admin/6377589/conversation/210435?view=List

@Nathanjp91 Nathanjp91 requested a review from rslota June 7, 2023 12:11
@Nathanjp91 Nathanjp91 merged commit 96dca09 into master Jun 7, 2023
@owencjones owencjones changed the title [IO-1203] Fix and test for complex polygons [IO-1230] Fix and test for complex polygons Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants