-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IO-1203] Missing dataset fields #617
Conversation
IO-1203 BUG: the fetch_remote_files() method in darwin.client incorrectly returns null for 3 parameters
BUG submission from: John Wilkie
Impact from darwin.dataset.remote_dataset_v2 import RemoteDatasetV2 client = Client.from_api_key('ApiKey') Team & Dataset Link Intercom ticket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. Seeing as this is a bug with high prio let's get it merged so that it can go out as needs dictate - can we ticket beefing up the tests, given that your fix for them basically introduced the first ones? 👍🏻
QA Pass - Went over this on a call with Nathan and can confirm the correct parameters are now returned |
Problem
Dataset items created via parse method lack the workflow status, id and dataset slug fields
Solution
add parsing these into the object, dataset_slug is not a a part of the json response and has to be passed into the parse function manually, added in as an optional field with default of "n/a" to preserve any existing functionality
Changelog
Items created via underlying parse method should correctly identify workflows they are attached to and the dataset they are a part of.