Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IO-1203] Missing dataset fields #617

Merged
merged 5 commits into from
Jul 5, 2023
Merged

[IO-1203] Missing dataset fields #617

merged 5 commits into from
Jul 5, 2023

Conversation

Nathanjp91
Copy link
Contributor

Problem

Dataset items created via parse method lack the workflow status, id and dataset slug fields

Solution

add parsing these into the object, dataset_slug is not a a part of the json response and has to be passed into the parse function manually, added in as an optional field with default of "n/a" to preserve any existing functionality

Changelog

Items created via underlying parse method should correctly identify workflows they are attached to and the dataset they are a part of.

@linear
Copy link

linear bot commented Jun 15, 2023

IO-1203 BUG: the fetch_remote_files() method in darwin.client incorrectly returns null for 3 parameters

BUG submission from: John Wilkie
Summary (describe an issue):
the fetch_remote_files() method in darwin.client incorrectly returns null for 3 parameters:

  • dataset_slug
  • current_workflow_Id
  • current_workflow
    Share Loom/Screenshots with Console/Network opened:
    N/A
    Darwin affected version
    V2
    Environment (production/staging; browser and OS version)

Impact
All (all Darwin users are impacted)
Priority
🟠 High - important issue, but has workaround
Steps to reproduce
Run the below Python script for any remote dataset with items in a workflow and observe the above described problem

from darwin.dataset.remote_dataset_v2 import RemoteDatasetV2
from darwin.client import Client

client = Client.from_api_key('ApiKey')
dataset = RemoteDatasetV2(client=client, team='team_slug', dataset_id=dataset_id, name='dataset_name', slug='dataset_slug')
items = [i for i in dataset.fetch_remote_files()]
print(items)
Expected Behaviour

Team & Dataset Link

Intercom ticket
https://app.intercom.com/a/inbox/pb9z3asr/inbox/admin/6377589/conversation/210435?view=List

Copy link
Contributor

@owencjones owencjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Seeing as this is a bug with high prio let's get it merged so that it can go out as needs dictate - can we ticket beefing up the tests, given that your fix for them basically introduced the first ones? 👍🏻

darwin/item.py Outdated Show resolved Hide resolved
@Nathanjp91 Nathanjp91 requested a review from rslota June 26, 2023 13:57
@PaulWhiteQA
Copy link

QA Pass - Went over this on a call with Nathan and can confirm the correct parameters are now returned

@Nathanjp91 Nathanjp91 merged commit f118ae6 into master Jul 5, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants