Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IO-1018][internal] Create Dataset meta method #621

Merged
merged 2 commits into from
Jun 27, 2023
Merged

[IO-1018][internal] Create Dataset meta method #621

merged 2 commits into from
Jun 27, 2023

Conversation

owencjones
Copy link
Contributor

Problem

Meta objects had no way of creating datasets, which blocks workflows.

Solution

Added a simple create dataset function to the DatasetMeta object, with tests.

Changelog

Implemented previously NotRaisedException raising function create_dataset on DatasetMeta
Added unit tests for creation of datasets.

@linear
Copy link

linear bot commented Jun 22, 2023

dataset: Optional[Dataset] = None

try:
self._validate_slug(slug)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not blocking but I feel like this has some crossover with the pydantic validation functions and we could reuse them.

Copy link
Contributor

@Nathanjp91 Nathanjp91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think stuff like the Query's should be an @property so they can just be called like dataset.items.where() (ie without the function call). Although I'm not too sure on datasetmeta having a dataset field, maybe hidden field? Not part of this PR though.

@owencjones owencjones merged commit b547c64 into master Jun 27, 2023
@owencjones
Copy link
Contributor Author

owencjones commented Jun 27, 2023

LGTM. I think stuff like the Query's should be an @property so they can just be called like dataset.items.where() (ie without the function call). Although I'm not too sure on datasetmeta having a dataset field, maybe hidden field? Not part of this PR though.

Fair comment, will add as a ticket, or include in another ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants