Update CLI dataset pull success message #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brain-geek
force-pushed
the
update-darwin-cli-download-message
branch
from
9143d89
to
4dd1800
Compare
Nathanjp91
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Right now, after you download the dataset via
dataset pullone of the messages isGoing to download ... files to /Users/..../images..As is, when you copy this path you also copy the dot in the end, which leads to
/Users/...../images. does not exist.. This is inconvenient.Solution
Separate the path and the dot in the message formatting.
Changelog
Improve dataset download message.