[IO-1539] ocv dependency group #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IO-1539 darwin-py cv2 optional dependency
add opencv as an optional dependency installable via pip install darwin[ocv] |
brain-geek
reviewed
Aug 16, 2023
brain-geek
reviewed
Aug 16, 2023
README.md
Outdated
| @@ -36,6 +36,12 @@ If you wish to use the PyTorch bindings, then you can use the `ml` flag to insta | |||
| pip install darwin-py[ml] | |||
| ``` | |||
|
|
|||
| If you wish to use LongVideo frame extraction, then you can use the `ocv` flag to install all the additional requirements | |||
There was a problem hiding this comment.
LongVideo is the internal name. Maybe we have some customer-facing name?
There was a problem hiding this comment.
Is there anything we are calling it for customers?
brain-geek
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Long Video Support will require the addition of the opencv python packages for video frame extraction
Solution
Adds a new dependency group to install opencv-python-headless optionally
Changelog
LongVideo Dependency support added