-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IO-1607][internal] Hotfix for Yolov8 #649
Conversation
IO-1607 BUG: Yolo v8 export generated in incorrect format (json instead of .txt and .labels) + slightly unclear definition of simple vs complex polygons
BUG submission from: Patryk Gronostajski Michal and Owen seem to have already figured out the first part, however, the simple vs complex polygon issue still needs to be investigated. Currently, polygons aren't exported even if they are simple polygons. More information in the slack thread linked below. I'll attach an example of the same export in yolov8, darwin json v2 and a SS of the polygons.
Customer Name Renewal timeline ARR Tier Assigned CSM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
if type == "bounding_box": | ||
return YoloSegmentedAnnotationType.BOUNDING_BOX | ||
elif type == "polygon": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is complex_polygon/circle/other annotation types not applicable to YOLO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Largely speaking, Yolo has historically been bounding boxes, and now supports polygons too, but ellipses, points, and other types are not supported - with many (2D plane) types, we could still process the bounding box and include it, but this wasn't in scope of the feature, and it was decided to include only bbox and simple polys for now.
Problem
YoloV8 was misidentifying items as complex polygons and refusing to export them.
Solution
Improved identification logic, and added test case and tolerated old scenario in case it's needed for anything.
Changelog
Refactor to YoloV8 exporter
Test added