[IO-1276] 3-step upload #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
October 12, 2023 17:22
added 11 commits
October 19, 2023 18:14
…bers unnecessary at upload
Nathanjp91
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
LGTM as per our prior call. Like the streamlining of the ItemLayout into singular object and think we should use this approach where we can rather than having seperate objects for everything. It means more up front code in the validators I think but means later code won't have to require so many checks on different objects and Union[v1, v2] typing.
owencjones
commented
Oct 24, 2023
| @@ -56,7 +56,7 @@ warn_untyped_fields = true | |||
|
|
|||
| [tool.ruff] | |||
| select = ["E", "F", "C"] | |||
| ignore = ["E203", "E402"] | |||
| ignore = ["E203", "E402", "E501"] | |||
There was a problem hiding this comment.
This allows us to leave this rule to mypy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, we use the old code for upload
Solution
Implemented DTOs and functions to upload using the V2 API.
Changelog
Added item uploads functions
Added item DTOs and validators
Added relevant tests