[PY-401][external] Restore Meta Item & ItemQuery functions #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PY-401 Restore item from archive
ex. Could be concurrent with IO-1987 |
owencjones
approved these changes
Nov 14, 2023
| ], | ||
| json={}, | ||
| ) | ||
| item.restore() |
There was a problem hiding this comment.
As with the other one, I would sad path these, but in these, they are small enough, that it isn't a massive deal. Red/Green/Refactor is a good approach.
There was a problem hiding this comment.
Quick Q on this - Since neither item.restore() or item_query.restore() take any parameters nor do they return anything, what could we consider the sad path?
There was a problem hiding this comment.
@owencjones I discussed these tests with Nathan - Since they don't return anything or take any arguments, there should only be one path these functions can actually take
Error responses from the API are covered in the underlying Core method tests. Given this, I'll proceed to merge but let me know if you disagree or have any other thoughts
| ], | ||
| json={}, | ||
| ) | ||
| item_query.restore() |
There was a problem hiding this comment.
And with this one ideally, but again, small ticket, not the end of the world.
The thing I would aim to be testing is each path through the function
ChristofferEdlund
pushed a commit
that referenced
this pull request
Nov 17, 2023
* Meta functions & tests to restore items * Test fixes
Nathanjp91
added a commit
that referenced
this pull request
Dec 12, 2023
* fixing test * added polygon and complex polygon tests with bounding boxes * extended convertion tests * formatter * updated test to reflect adding of bounding box * updated tests to check for new format * added additional test for box and tag * removed prints * black reformat * black format * removed an import * added schema ref * reformated utils * added support RemoteDatasetV1 parsing and updated tests * black fomrat * additional black magic * fixed conflic * minor fixes * removed ignore of empty files * updated tests for new (old) behaviour * added test case * updated test * updated code to work with bounding boxes and polygon, also added toggle to use all or only non empty annotations to local dataset class * black * adjusting paths to pass tests * black * handling polyg and bbox bounding box anno * [PY-401][external] Restore Meta Item & ItemQuery functions (#718) * Meta functions & tests to restore items * Test fixes * [PY-402][external] Archive Meta Item & ItemQuery functions (#719) * Meta functions & tests to archive items * Test improvements * Linting * [PY-403][external] Set Priority Meta Item & ItemQuery functions (#720) * Fixed missing path parameter in core move items to folder method * Fixed missing priority parameter in core set item priority method * Linting * Meta Item & ItemQuery functions to move between folders * Update darwin/future/tests/meta/queries/test_item.py Co-authored-by: Owen Jones <owencjones+github@gmail.com> * Added sad path tests * Meta functions & tests to set item priority * Linting --------- Co-authored-by: Owen Jones <owencjones+github@gmail.com> * automatic ruff --fix changes (#723) * automatic ruff --fix changes * black changes * revert of client * minor updates to tests * added make polygon tests for darwin_v2 format * updating tests to accomidate darwin V2 format * black * added nifty V2 test * black * refactor * ruff --fix * removed try catch in stacked targets * removed print * Reverted specific files to state in commit 09b105e * converting complex and regular polygon to import format * added a potential e2e import fix * removed debug prints * latest sync * updated code to pass e2e tests * black and ruff --fix all * updated formatting * minor changes to complex polygon * minor fix * black * minor updates based on comments * added PolygonPath and PolygonPaths definitions * merge * extended convertion tests * local changes * reverted changes to internal darwin format, convertion to v2 only done when writing to file now * black * ruff and black * removed settings.json changes * reverting to non-v2 data.zip * merged darwin_v1_test changes from origin master * changed json stream to normal json * Fix `RecursionError` in `Item` class (#732) * Item missing `__str__` method raises `RecursionError` * update `MetaBase` class - add the missing `__str__` method * commiting changes * fixed json-stream error when checking for non-empty lists * remove unused import * fixed video to image convertion bug when folders are used * removed debug print * removed debug print --------- Co-authored-by: John Wilkie <124276291+JBWilkie@users.noreply.github.com> Co-authored-by: Owen Jones <owencjones+github@gmail.com> Co-authored-by: Nathan Perkins <nathanjp91@gmail.com> Co-authored-by: saurbhc <sc@saurabhchopra.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently no Meta methods for restoring items
Solution
Introduced functions to do this for Meta Items & ItemQuery objects
Changelog
Meta methods to restore Items & ItemQuery objects