[PY-399][externa] Meta methods & tests for setting layout #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PY-399 Set item layout
ex. |
owencjones
reviewed
Nov 22, 2023
| if not isinstance(layout, ItemLayout): | ||
| try: | ||
| layout = ItemLayout(**layout) | ||
| except ValueError: |
There was a problem hiding this comment.
Do these not throw ValidationError, potentially as well?
There was a problem hiding this comment.
Nice spot, they could indeed
Will except ValidationError as well in these
| @@ -143,3 +144,25 @@ def archive(self) -> None: | |||
| ids = [item.id for item in self] | |||
| filters = {"item_ids": [str(item) for item in ids]} | |||
| archive_list_of_items(self.client, team_slug, dataset_ids, filters) | |||
|
|
|||
| def set_layout(self, layout: ItemLayout) -> None: | |||
| if "team_slug" not in self.meta_params: | |||
There was a problem hiding this comment.
I'd maybe space out these individual ifs a bit, but that's a minor point!
There was a problem hiding this comment.
...actually a bit surprised that Black didn't tbh
There was a problem hiding this comment.
Good point, good for readability
| @@ -226,3 +226,44 @@ def test_archive_with_bad_team_slug(item: Item) -> None: | |||
| with pytest.raises(AssertionError): | |||
| item.meta_params["team_slug"] = 123 | |||
| item.archive() | |||
|
|
|||
There was a problem hiding this comment.
These tests are bang on, nice one
Nathanjp91
reviewed
Nov 30, 2023
Nathanjp91
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently no Meta methods for setting item layout
Solution
Introducted functions to do this for Meta Items & ItemQuery objects
Changelog
Meta methods to set the layout of Items & ItemQuery objects