Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PY-613] BUG: Unable to export Nifti files without file extension. #735

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

saurbhc
Copy link
Member

@saurbhc saurbhc commented Nov 29, 2023

Problem

Unable to export Nifti files without file extension.

Solution

This is a bug, which should be performing checks on slot's file_name.
Updated the filename checks to work on slot level.

Changelog

Fix Nifti file export without a file extension.

@saurbhc saurbhc added the bug Something isn't working label Nov 29, 2023
@saurbhc saurbhc self-assigned this Nov 29, 2023
Copy link

linear bot commented Nov 29, 2023

PY-613 BUG: Unable to export Nifti files without file extension.

The team at Kaliber are unable to export DICOM files they've annotated as the files don't have filenames.

The customer has shared that they receive error JSONs after exporting that shares this message: "{"error": "You are trying to export to nifti. Filename should contain either .nii, .nii.gz or .dcm extension. Are you sure this is medical data?"}". Because of this, they don't have a way to export their DICOM files as Nifti within the platform.

N/A

Impact:

  • Single (only one customer impacted)
  • Some (few customers are impacted)
  • All (all Darwin users are impacted)
  • ⚠️ Strategic customer
  1. Upload a DICOM file with no file extension in the filename.
  2. Make some annotations on the file.
  3. Attempt to generate an export with the file using Nifti format.
  4. Once the export is generated, download and open the files.
  5. Observe if you receive an error JSON.

Expected Behaviour:

Team - https://darwin.v7labs.com/super_admin/teams/2498
Dataset - https://darwin.v7labs.com/datasets/699814/dataset-management

https://app.intercom.com/a/inbox/pb9z3asr/inbox/admin/5720549/conversation/318162?view=List

22,000

Nell

@saurbhc saurbhc marked this pull request as ready for review November 29, 2023 11:12
Copy link
Contributor

@Nathanjp91 Nathanjp91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good fix. No issues.

@saurbhc saurbhc merged commit c151da7 into master Nov 30, 2023
13 checks passed
@saurbhc saurbhc deleted the PY-613 branch November 30, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants