[PY-597] Darwin-py extra authenticate options #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBWilkie
approved these changes
Dec 12, 2023
darwin/cli.py
Outdated
| api_key = os.getenv("DARWIN_API_KEY") | ||
| api_key = os.getenv("DARWIN_API_KEY") or args.api_key | ||
| default_team = os.getenv("DARWIN_TEAM") or args.default_team | ||
| datasets_dir = os.getenv("DARWIN_DATASETS_DIR") or args.datasets_dir | ||
| if api_key: | ||
| print("Using API key from DARWIN_API_KEY") |
There was a problem hiding this comment.
When I pass an API key with --api_key, I see Using API key from DARWIN_API_KEY
Is this technically incorrect, since it's actually from a CLI arg?
There was a problem hiding this comment.
Same goes for the --default_team and --dataset_dir flags
There was a problem hiding this comment.
updated for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Darwin Authentication currently has no way to programmatically set authenticate options without engaging the CLI
Solution
Set extra options, allowing to pass in api-key, default-team and dataset directory as CLI flags, as well as setting env variables
.env
or via CLI commands
darwin authenticate --api_key {key} --default_team {team} --datasets_dir {dir}Changelog
darwin-py can now be authenticated via env variables and CLI flags without requiring input