[PY-626] Updates to import endpoint - annotation_properties
#760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurbhc
changed the title
annotation_properties
saurbhc
added a commit
that referenced
this pull request
Jan 25, 2024
…rting annotations (#759) * _import_properties WIP * fix tests for is_properties_enabled * add more logic * remove metadata file edge cases * update tests * fix import logic * rm breakpoint * update importer - fix client * remove print * update prints * udpate metadata_path check * update propertyvalue create logic * [PY-626] Updates to import endpoint - `annotation_properties` (#760) * handling properties data while importing annotations * add tests for _handle_annotation_data * update importer - add annotations_properties in payload of import annotations * update importer - rm _handle_properties code * fix test * update test * fix indent * add the missing return value * fix issues with multi_select create_property * rm `_msg` variable used in ValueError as they are not used again. * update list lookup -> to set for faster lookups * update `annotation_id_property_map` keys are moved from str -> tuple[str, str] * created a doc-block for _import_properties fn * [PY-665] - Update property-value object structure to support un-nested value field (#769) * update nested value changes for property-value objects * fix tests + fix linting * rm property field from PropertyValue object * add description & rm type in PropertyValue * update test-metadata files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
No support for handling properties data in import_annotation endpoint
Solution
add another function
_handle_propertieswhich addspropertiesas list of property data (as required by backend)TODO:
Changelog
Updates to import endpoint - Handle Properties data