[DAR-214][external Fixed unhandled annotation types in 1.0 conversion #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBWilkie
commented
Jan 23, 2024
| @@ -205,6 +205,9 @@ def _build_legacy_annotation_data( | |||
| # Poygons and complex polygons usually have attached bounding_box annotations | |||
| v1_data["bounding_box"] = data["bounding_box"] | |||
|
|
|||
| if not v1_data: | |||
| v1_data[annotation_class.annotation_type] = data | |||
|
|
|||
There was a problem hiding this comment.
This is how the entire function used to work. Basically if it's not a tag, bbox, or polygon, simply return the structure that we used to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A previous PR introduced in 0.8.45 broke the following annotation types when converting from 2.0 to 1.0 JSON:
Solution
Changelog
Fixed a bug that prevented certain annotation types from being converted from 2.0 to 1.0 JSON