Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Property import fixed, options -> property_values #774

Merged
merged 9 commits into from
Jan 29, 2024
Merged

[Bug] Property import fixed, options -> property_values #774

merged 9 commits into from
Jan 29, 2024

Conversation

saurbhc
Copy link
Member

@saurbhc saurbhc commented Jan 25, 2024 •
edited
Loading

Problem

Import breaks with properties, when parsing 'options' from Property in .v7/metadata.json

Solution

  • options is moved to property_values
  • type field is Optional[str] now.

Additional Changes:

  • frame_index for Video Annotation is fixed (per-annotation)
  • fix the annotation-import payload in case of null property-values

Changelog

[Bug] Property import fixed, options -> property_values, frame_index fixes

@saurbhc saurbhc added the bug Something isn't working label Jan 25, 2024
@saurbhc saurbhc self-assigned this Jan 25, 2024
@saurbhc saurbhc merged commit b3e52dd into master Jan 29, 2024
16 checks passed
@saurbhc saurbhc deleted the fix/properties-import branch January 29, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriiKlymchuk AndriiKlymchuk AndriiKlymchuk approved these changes

Assignees

@saurbhc saurbhc

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saurbhc @AndriiKlymchuk