Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLA-640] Updating metadata property values while importing annotations #780

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

saurbhc
Copy link
Member

@saurbhc saurbhc commented Feb 28, 2024

Problem

While importing annotations with properties, property-values which are not in annotation file but present in metadata.json are not created/updated in annotation-property.

Solution

Adding additional logic after annotation-properties are created/updated on the server. Logic is:

  1. get the latest team-properties
  2. only go ahead in the case when annotation-properties are present in team-properties
  3. build metadata-property-values set
  4. build team-property-values set
  5. extra values: diff b/w metadata & team property-values set
  6. update property with extra-property-values!

Changelog

Updating additional metadata property values while importing annotations

@saurbhc saurbhc added the enhancement New feature or request label Feb 28, 2024
@saurbhc saurbhc self-assigned this Feb 28, 2024
@saurbhc saurbhc changed the title [PLA-640] Updating additional metadata property values while importing annotations [PLA-640] Updating metadata property values while importing annotations Feb 28, 2024
@saurbhc saurbhc marked this pull request as ready for review February 28, 2024 14:49
Copy link
Collaborator

@JBWilkie JBWilkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested a few different scenarios importing single / multi select property values that didn't yet exist server-side, and it worked perfectly every time - LGTM!

Particularly like that it prints to console, nice visual feedback!

@saurbhc saurbhc merged commit 50e1c4c into master Feb 28, 2024
16 checks passed
@saurbhc saurbhc deleted the PLA-640 branch February 28, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants