Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLA-756] Existing properties are now imported without a .v7/manifest.json file #791

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

saurbhc
Copy link
Member

@saurbhc saurbhc commented Mar 15, 2024

Problem

When importing annotations with property values, if the .v7/manifest.json file isn't present, properties will be entirely skipped.

Solution

Team properties (if they exist) are passed along with annotations while importing them.

Changelog

Existing properties are now imported without a .v7/manifest.json file

Copy link

linear bot commented Mar 15, 2024

@saurbhc saurbhc changed the title [PLA-256] Existing properties are now imported without a `.v7/manifest.json file [PLA-256] Existing properties are now imported without a .v7/manifest.json file Mar 15, 2024
@saurbhc saurbhc changed the title [PLA-256] Existing properties are now imported without a .v7/manifest.json file [PLA-756] Existing properties are now imported without a .v7/manifest.json file Mar 15, 2024
@saurbhc saurbhc self-assigned this Mar 15, 2024
@saurbhc saurbhc added the enhancement New feature or request label Mar 15, 2024
@saurbhc saurbhc requested a review from JBWilkie March 18, 2024 13:32
Copy link
Collaborator

@JBWilkie JBWilkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested importing existing property values (single & multi-select) without the manifest and it worked in all cases

Imports also correctly raised ValueError when trying to import property values that don't exist in the team

Nice one!

@saurbhc saurbhc merged commit f6a50a2 into master Mar 19, 2024
16 checks passed
@saurbhc saurbhc deleted the PLA-726 branch March 19, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants