[DAR-1609][External] pull() never creates the properties metadata file in the annotations directory #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurbhc
reviewed
Apr 16, 2024
|
Let's also add a test case, maybe here? - which makes sure it moves the metadata.json file |
Co-authored-by: saurbhc <sc@saurabhchopra.co.uk>
Co-authored-by: saurbhc <sc@saurabhchopra.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When downloading annotation ZIPs when using
pull(), the properties manifest file is never created in the annotations directory. This is because despite the fact that we download the same ZIP file that the frontend provides, we first unzip the files in a temporary directory, then only move.jsonfiles to the annotations directory. This leaves the.v7folder behindSolution
If the properties metadata file is present, move it to the annotations directory
Changelog
Fixed a bug where downloading annotations with darwin-py would not include the properties metadata file