[DAR-1649][Internal] Update process_nifti to take custom ornt #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorfmanrobert
changed the title
shernshiou
approved these changes
Apr 18, 2024
JBWilkie
reviewed
Apr 19, 2024
JBWilkie
approved these changes
Apr 19, 2024
dorfmanrobert
deleted the
dar-1649-darwin-py-allow-non-lpi-nifti-annotation-processing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
process_niftifunction forces the annotations to be oriented as LPI. However, this function is used internally for model integrations running inference on medical volumes. This is an issue as medical BE changes are being made that allow some DICOM files to be stored in orientations that are not LPI. So, we want to allow the model integrations to passprocess_niftia custom orientation.Solution
We add an argument to
process_niftithat defaults to LPI (which is what it was before, although there was a typo in the actual value -- typo wasn't affecting the output though). This means model integrations can use it with custom orientations, but the public darwin-py api is unaffected.