Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAR-1165][DAR-1734][External] Polygons from other plane export correctly #828

Merged
merged 1 commit into from
Apr 26, 2024
Merged

[DAR-1165][DAR-1734][External] Polygons from other plane export correctly #828

merged 1 commit into from
Apr 26, 2024

Conversation

shernshiou
Copy link
Contributor

@shernshiou shernshiou commented Apr 25, 2024 •
edited
Loading

Problem

The polygons at Coronal and Sagittal are not exported.

Solution

Go through all the slots to ensure all the polygons are exported.

Fixes DAR-1165
Fixes DAR-1734

Changelog

  • Polygon from Coronal and Sagittal plane are exported correctly.

@linear Linear
Copy link

linear bot commented Apr 25, 2024

DAR-1165 BUG: Only Axial annotations are exported fron NPR views with polygon annotations

@shernshiou shernshiou marked this pull request as ready for review April 25, 2024 13:11
@shernshiou shernshiou self-assigned this Apr 25, 2024
@shernshiou
Copy link
Contributor Author

Result

image

@shernshiou shernshiou changed the title [DAR-1165][External] Polygons from other plane export correctly [DAR-1165][DAR-1734][External] Polygons from other plane export correctly Apr 26, 2024
@linear Linear
Copy link

linear bot commented Apr 26, 2024

DAR-1734 BUG: Nifti exports are either empty or have annotations at one slice per volume

JBWilkie
JBWilkie approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@JBWilkie JBWilkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested fix on problematic data provided to us by the client, and NifTI exports of those files are no longer missing any annotations

@shernshiou shernshiou merged commit d06df59 into master Apr 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBWilkie JBWilkie JBWilkie approved these changes

@tomvars tomvars Awaiting requested review from tomvars

Assignees

@shernshiou shernshiou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shernshiou @JBWilkie