Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAR-2240][External] Typing improvements & better missing image error message #845

Merged
merged 1 commit into from
May 21, 2024
Merged

[DAR-2240][External] Typing improvements & better missing image error message #845

merged 1 commit into from
May 21, 2024

Conversation

JBWilkie
Copy link
Collaborator

Problem

  • A sometimes unclear missing image error message & missing type hints

Solution

  • Added missing type hints
  • Improved missing image error by displaying the path to where the missing file should have been

Changelog

  • Improved type hints & missing image error message

@linear Linear
Copy link

linear bot commented May 21, 2024

DAR-2240 Typing improvements and error output

@JBWilkie JBWilkie merged commit 979aebb into master May 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shernshiou shernshiou shernshiou approved these changes

@saurbhc saurbhc Awaiting requested review from saurbhc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JBWilkie @shernshiou