Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAR-2228][External] - Fix for NifTI exports containing no polygons #855

Merged
merged 4 commits into from
Jun 5, 2024
Merged

[DAR-2228][External] - Fix for NifTI exports containing no polygons #855

merged 4 commits into from
Jun 5, 2024

Conversation

JBWilkie
Copy link
Collaborator

@JBWilkie JBWilkie commented Jun 5, 2024 •
edited
Loading

Problem

A change made in DAR-1165 accidentally introduced a bug whereby NifTI exports of files containing no polygons would fail.

Solution

  • 1: Only attempt to export polygons if any polygon annotations are present
  • 2: Added unit tests to make sure we're calling the polygon to volume & mask to volume functions when appropriate

Changelog

Fixed issue that caused NifTI exports without polygons to fail

@linear Linear
Copy link

linear bot commented Jun 5, 2024

DAR-2228 Missing affine or shape when exporting to NifTI

@JBWilkie JBWilkie merged commit 11a7811 into master Jun 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shernshiou shernshiou shernshiou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JBWilkie @shernshiou