[IO-1402][internal] Refactoring deployment #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
July 24, 2023 15:05
Nathanjp91
reviewed
Jul 26, 2023
.github/workflows/deploy.yml
Outdated
| verbose: true | ||
|
|
||
| - name: "TEST: Release code as new release on Test Pypi" | ||
| if: ${{ env.IS_TEST_RELEASE == 'true' }} |
There was a problem hiding this comment.
Is it possible to adopt a similar approach for darwin-py so we can test deployments?
There was a problem hiding this comment.
Well, it doesn't yet work here, but yeah, it actually won't be too much work once it works here - I had the same thought, because I put the pipeline ticket on the board ages ago now but can't get it into sprint.
Nathanjp91
approved these changes
Jul 26, 2023
added 12 commits
July 26, 2023 11:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployment is blocked by deprecation of a hook, which has necessitated this refactor.
If this change is successful, then:
Building of artefacts is tested and seems to work, so does SDist. Trouble encountered testing on-release actions without being on release.
NB: There is currently a block in the code to prevent deployment to Pypi (the URL is deliberately wrong) - to allow diagnosis of the pipeline without chance that it will deploy.
upolygonis a dependency of many things, so a real deployment has potential to break things!