Reland: [v8] Stop using deprecated fields of v8::FastApiCallbackOptions #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two fields on the v8::FastApiCallbackOptions struct were deprecated recently, fallback and wasm_memory. This PR removes uses of these two fields in node.js. This change is a refactoring and does not add new features. Therefore existing tests should be sufficient.
pthier
pushed a commit
that referenced
this pull request
Jul 15, 2024
…ns (#196) * Reland: [v8] Stop using deprecated fields of v8::FastApiCallbackOptions Two fields on the v8::FastApiCallbackOptions struct were deprecated recently, fallback and wasm_memory. This PR removes uses of these two fields in node.js. This change is a refactoring and does not add new features. Therefore existing tests should be sufficient. * return correct type
victorgomes
pushed a commit
that referenced
this pull request
Aug 22, 2024
…ns (#196) * Reland: [v8] Stop using deprecated fields of v8::FastApiCallbackOptions Two fields on the v8::FastApiCallbackOptions struct were deprecated recently, fallback and wasm_memory. This PR removes uses of these two fields in node.js. This change is a refactoring and does not add new features. Therefore existing tests should be sufficient. * return correct type
pthier
pushed a commit
that referenced
this pull request
Oct 2, 2024
…ns (#196) * Reland: [v8] Stop using deprecated fields of v8::FastApiCallbackOptions Two fields on the v8::FastApiCallbackOptions struct were deprecated recently, fallback and wasm_memory. This PR removes uses of these two fields in node.js. This change is a refactoring and does not add new features. Therefore existing tests should be sufficient. * return correct type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fields on the v8::FastApiCallbackOptions struct were deprecated recently, fallback and wasm_memory. This PR removes uses of these two fields in node.js.
This change is a refactoring and does not add new features. Therefore existing tests should be sufficient.