Implement the basic audio engine. #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleDsz
reviewed
Sep 18, 2024
hasenbanck
force-pushed
the
audio_engine
branch
from
8a0c93f
to
718a5b0
Compare
hasenbanck
changed the title
hasenbanck
force-pushed
the
audio_engine
branch
3 times, most recently
from
5ec19a4
to
5f89183
Compare
|
Ok, I'm finished here now. |
- Add utility crate for some containers and basic collision handling. - Add audio crate with background music, sound effects and spatial, ambient sound effects. - Re-Use collision code between frustum culling and audio engine. - Improve performance of frustum culling. - Use global thread pool for rayon (so that we can re-use the thread pool with other creates). - Make game file loader sync (easier to share). - Update some dependencies. - Remove some unused code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lays the foundation for the audio engine. It implements the main menue sounds, music and ambient, spatial sound. Entity and Effect sound effects will be implemented later. Once the new UI code is finished, I will also start to expose the configuration values (mainly volume control).
The PR contains a "util" library, which will contain code that other libraries might want to use (mainly containers and collision code). I will also use these containers for the render engine later (for async loading etc.). I took the liberty to make the usage of the game archive loader a little bit easier (since we want to use it from async threads later). I also removed the unmaintained collision-rs library and re-use collision code between the frustum culling and the audio engine.