Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Popover documentation and live examples #3587

Merged
merged 12 commits into from
Sep 4, 2024
Merged

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Aug 7, 2024

Added Popover documentation and live examples based on the document.

@github-actions github-actions bot added the Language unchecked English language check has not been done label Aug 7, 2024
@web-padawan web-padawan force-pushed the docs/popover branch 3 times, most recently from 0668c4c to 6d5326d Compare August 12, 2024 10:26
@web-padawan web-padawan marked this pull request as ready for review August 12, 2024 10:26
@web-padawan
Copy link
Member Author

Vale complains about some words e.g. mouseout, listbox, autofocus.

Copy link
Contributor

@rolfsmeds rolfsmeds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropdown field example

  • Missing aria-label
  • Doesn't open on focus
  • Closes on selections except on to-field?

User Menu

  • Doesn't open on kbd-click

articles/components/popover/index.adoc Outdated Show resolved Hide resolved
articles/components/popover/index.adoc Outdated Show resolved Hide resolved
articles/components/popover/index.adoc Outdated Show resolved Hide resolved
articles/components/popover/index.adoc Outdated Show resolved Hide resolved
articles/components/popover/index.adoc Outdated Show resolved Hide resolved
articles/components/popover/index.adoc Outdated Show resolved Hide resolved
articles/components/popover/index.adoc Outdated Show resolved Hide resolved
articles/components/popover/index.adoc Outdated Show resolved Hide resolved
articles/components/popover/index.adoc Outdated Show resolved Hide resolved
articles/components/popover/index.adoc Outdated Show resolved Hide resolved
@web-padawan
Copy link
Member Author

Doesn't open on focus

Looks like we have a problem with focus trigger combined with nested components like vaadin-select: opening the vaadin-select-overlay makes focus leave vaadin-popover-overlay and then the popover closes.

Reported vaadin/web-components#7652 and updated the description to only use "click" for now.

@web-padawan
Copy link
Member Author

User Menu
Doesn't open on kbd-click

This is problematic as we don't have "keyboard click" logic vaadin-avatar used here. Workarounded this for now by wrapping vaadin-avatar in vaadin-button with theme="icon tertiary-inline" and using button as a target.

@russelljtdyer russelljtdyer removed the Language unchecked English language check has not been done label Aug 26, 2024
@web-padawan web-padawan force-pushed the docs/popover branch 2 times, most recently from d768ab4 to 5865777 Compare August 28, 2024 13:19
@web-padawan
Copy link
Member Author

Rebased and updated the "drop-down field" example to also open on focus in addition to click.

@web-padawan web-padawan merged commit fd2e1e3 into latest Sep 4, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants