-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: put getDefaultValidator implementation behind a feature flag #3597
Merged
vursen
merged 14 commits into
master
from
refactor/put-default-validator-behind-feature-flag
Aug 23, 2022
Merged
refactor!: put getDefaultValidator implementation behind a feature flag #3597
vursen
merged 14 commits into
master
from
refactor/put-default-validator-behind-feature-flag
Aug 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
force-pushed
the
refactor/put-default-validator-behind-feature-flag
branch
from
August 15, 2022 13:51
8aba2e1
to
1008be9
Compare
knoobie
reviewed
Aug 16, 2022
...t/vaadin-date-picker-flow/src/main/java/com/vaadin/flow/component/datepicker/DatePicker.java
Outdated
Show resolved
Hide resolved
vursen
force-pushed
the
refactor/put-default-validator-behind-feature-flag
branch
3 times, most recently
from
August 19, 2022 13:52
bb2710d
to
c366e44
Compare
vursen
force-pushed
the
refactor/put-default-validator-behind-feature-flag
branch
from
August 19, 2022 13:52
c366e44
to
538a76f
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
yuriy-fix
approved these changes
Aug 22, 2022
This ticket/PR has been released with Vaadin 23.2.0.beta3 and is also targeting the upcoming stable 23.2.0 version. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR puts the
getDefaultValidator
implementation behind the feature flagforceFieldValidation
as we agreed in vaadin/flow#14285 (comment).Part of vaadin/platform#3066
A follow-up to #3381
Type of change
Checklist